Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!:deprecate QML upload from bus #120

Merged
merged 10 commits into from
Nov 5, 2024
Merged

refactor!:deprecate QML upload from bus #120

merged 10 commits into from
Nov 5, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Sep 18, 2024 •
edited by coderabbitai bot
Loading

never worked right, causes more issues than it helps

companion to OpenVoiceOS/ovos-gui#53

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Simplified GUI interface by removing support for remote server configurations.
    • Introduced a new method for caching GUI resources, enhancing resource management.
    • Transitioned to a more abstract handling of GUI resources, moving away from file uploads.

  • Bug Fixes

    • Streamlined the GUIInterface class by eliminating deprecated functionalities, reducing complexity.
    • Improved error handling for resource name validation, enforcing stricter checks on page names.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 18, 2024 •
edited
Loading

Warning

Rate limit exceeded

@JarbasAl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 8 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 202b416 and b6b37b8.

Walkthrough

The changes involve significant modifications to the GUIInterface class in the gui.py file. Key functionalities related to remote GUI server handling and the uploading of GUI pages have been removed. This includes the elimination of the remote_server parameter, the upload_gui_pages method, and the _pages2uri method. Additionally, a new method for caching GUI resources has been introduced, and error handling has been updated to enforce stricter validation of resource names.

Changes

File Path Change Summary
ovos_bus_client/apis/gui.py Removed upload_gui_pages, _pages2uri, and updated __init__ and _normalize_page_name methods in GUIInterface. Added _cache_gui_files method.

Sequence Diagram(s)

(No sequence diagrams generated as the changes do not warrant a visual representation of control flow.)

Suggested labels

documentation

Poem

🐇 In the garden of code, changes bloom,
Remote servers fade, making room.
Pages once uploaded, now take flight,
A simpler path, oh what a sight!
With every line, we hop along,
To a new tune, we sing our song! 🎶

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@JarbasAl JarbasAl marked this pull request as draft September 18, 2024 21:30
@JarbasAl JarbasAl mentioned this pull request Sep 18, 2024
Merged
JarbasAl added a commit to OpenVoiceOS/OVOS-workshop that referenced this pull request Sep 18, 2024
@JarbasAl
fix:cache_gui_files
bf1acd6 
companion to OpenVoiceOS/ovos-gui#53 and OpenVoiceOS/ovos-bus-client#120

this should be merged first as it does not require the others to work and does not break anything in the wild
@JarbasAl JarbasAl mentioned this pull request Sep 18, 2024
Closed
JarbasAl added a commit to OpenVoiceOS/OVOS-workshop that referenced this pull request Sep 18, 2024
@JarbasAl
fix:cache_gui_files
d988c36 
companion to OpenVoiceOS/ovos-gui#53 and OpenVoiceOS/ovos-bus-client#120

this should be merged first as it does not require the others to work and does not break anything in the wild
JarbasAl added a commit to OpenVoiceOS/ovos-ocp-audio-plugin that referenced this pull request Sep 19, 2024
@JarbasAl
fix:cache_gui_files
d90d829 
companion to OpenVoiceOS/ovos-gui#53 and OpenVoiceOS/ovos-bus-client#120

this should be merged first as it does not require the others to work and does not break anything in the wild
JarbasAl added a commit to OpenVoiceOS/ovos-ocp-audio-plugin that referenced this pull request Sep 19, 2024
@JarbasAl
fix:cache_gui_files
98610a5 
companion to OpenVoiceOS/ovos-gui#53 and OpenVoiceOS/ovos-bus-client#120

this should be merged first as it does not require the others to work and does not break anything in the wild
JarbasAl added a commit to OpenVoiceOS/ovos-ocp-audio-plugin that referenced this pull request Sep 19, 2024
@JarbasAl
fix:cache_gui_files
e671225 
companion to OpenVoiceOS/ovos-gui#53 and OpenVoiceOS/ovos-bus-client#120

this should be merged first as it does not require the others to work and does not break anything in the wild
@JarbasAl JarbasAl mentioned this pull request Sep 19, 2024
Closed
JarbasAl added a commit to OpenVoiceOS/ovos-gui-plugin-shell-companion that referenced this pull request Sep 19, 2024
@JarbasAl
fix:cache_gui_files
0c1e899 
companion to OpenVoiceOS/ovos-gui#53 and OpenVoiceOS/ovos-bus-client#120

this should be merged first as it does not require the others to work and does not break anything in the wild
JarbasAl added a commit to OpenVoiceOS/ovos-gui-plugin-shell-companion that referenced this pull request Sep 19, 2024
@JarbasAl
fix:cache_gui_files
b73686c 
companion to OpenVoiceOS/ovos-gui#53 and OpenVoiceOS/ovos-bus-client#120

this should be merged first as it does not require the others to work and does not break anything in the wild
JarbasAl added a commit to OpenVoiceOS/ovos-gui-plugin-shell-companion that referenced this pull request Sep 19, 2024
@JarbasAl
fix:cache_gui_files
42cb885 
companion to OpenVoiceOS/ovos-gui#53 and OpenVoiceOS/ovos-bus-client#120

this should be merged first as it does not require the others to work and does not break anything in the wild
This was referenced Sep 19, 2024
Closed
Merged
@JarbasAl JarbasAl marked this pull request as ready for review September 20, 2024 21:03
@JarbasAl JarbasAl mentioned this pull request Sep 20, 2024
Merged
@JarbasAl
Copy link
Member Author

marked as breaking because it does change the public api, but nothing in our org is using the removed stuff so it should be safe

it may also cause issues in existing docker installs, but GUI in docker never worked quite right, the goal is precisely to make docker work correctly, if all containers are updated this won't cause issues there either

@JarbasAl JarbasAl force-pushed the deprecate_QML_upload branch from 346ff66 to fa11187 Compare October 21, 2024 14:13
JarbasAl added a commit to OpenVoiceOS/ovos-skill-pyradios that referenced this pull request Nov 5, 2024
@JarbasAl
fix: allow latest ovos-gui changes
8d43fa0 
companion to OpenVoiceOS/ovos-bus-client#120 and OpenVoiceOS/ovos-gui#53
JarbasAl added a commit to OpenVoiceOS/ovos-skill-naptime that referenced this pull request Nov 5, 2024
@JarbasAl
fix: allow latest ovos-gui changes
f469fde 
companion to OpenVoiceOS/ovos-bus-client#120 and OpenVoiceOS/ovos-gui#53
JarbasAl added a commit to OpenVoiceOS/ovos-skill-spotify that referenced this pull request Nov 5, 2024
@JarbasAl
fix: allow latest ovos-gui changes
1df0fc3 
companion to OpenVoiceOS/ovos-bus-client#120 and OpenVoiceOS/ovos-gui#53
JarbasAl added a commit to OpenVoiceOS/ovos-skill-somafm that referenced this pull request Nov 5, 2024
@JarbasAl
fix: allow latest ovos-gui changes
a8cee0a 
companion to OpenVoiceOS/ovos-bus-client#120 and OpenVoiceOS/ovos-gui#53
JarbasAl added a commit to OpenVoiceOS/ovos-skill-tunein that referenced this pull request Nov 5, 2024
@JarbasAl
fix: allow latest ovos-gui changes
2b944ce 
companion to OpenVoiceOS/ovos-bus-client#120 and OpenVoiceOS/ovos-gui#53
JarbasAl added a commit to OpenVoiceOS/ovos-skill-alerts that referenced this pull request Nov 5, 2024
@JarbasAl
fix: allow latest ovos-gui changes
74f4eed 
companion to OpenVoiceOS/ovos-bus-client#120 and OpenVoiceOS/ovos-gui#53
JarbasAl added a commit to OpenVoiceOS/ovos-skill-news that referenced this pull request Nov 5, 2024
@JarbasAl
fix: allow latest ovos-gui changes
b729025 
companion to OpenVoiceOS/ovos-bus-client#120 and OpenVoiceOS/ovos-gui#53
JarbasAl added a commit to OpenVoiceOS/ovos-skill-parrot that referenced this pull request Nov 5, 2024
@JarbasAl
fix: allow latest ovos-gui changes
fdfeea9 
companion to OpenVoiceOS/ovos-bus-client#120 and OpenVoiceOS/ovos-gui#53
JarbasAl added a commit to OpenVoiceOS/ovos-skill-local-media that referenced this pull request Nov 5, 2024
@JarbasAl
fix: allow latest ovos-gui changes
3b63567 
companion to OpenVoiceOS/ovos-bus-client#120 and OpenVoiceOS/ovos-gui#53
JarbasAl added a commit to OpenVoiceOS/ovos-skill-wallpapers that referenced this pull request Nov 5, 2024
@JarbasAl
fix: allow latest ovos-gui changes
0726456 
companion to OpenVoiceOS/ovos-bus-client#120 and OpenVoiceOS/ovos-gui#53
This was referenced Nov 5, 2024
Merged
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Closed
Closed
Merged
JarbasAl added a commit to OpenVoiceOS/ovos-skill-wallpapers that referenced this pull request Nov 5, 2024
@JarbasAl
fix:allow workshop 3.0.0 (#13)
8ae2f1e 
* fix:allow workshop 3.0.0

* fix: allow latest ovos-gui changes

companion to OpenVoiceOS/ovos-bus-client#120 and OpenVoiceOS/ovos-gui#53
JarbasAl added a commit to OpenVoiceOS/ovos-skill-local-media that referenced this pull request Nov 5, 2024
@JarbasAl
fix: allow latest ovos-gui changes (#14)
b85f69a 
* fix: allow latest ovos-gui changes

companion to OpenVoiceOS/ovos-bus-client#120 and OpenVoiceOS/ovos-gui#53

* fix: allow latest ovos-gui changes

companion to OpenVoiceOS/ovos-bus-client#120 and OpenVoiceOS/ovos-gui#53
JarbasAl added a commit to OpenVoiceOS/ovos-skill-parrot that referenced this pull request Nov 5, 2024
@JarbasAl
fix:allow workshop 2.0.0 (#19)
28c2fb8 
* fix:allow workshop 3.0.0

* fix: allow latest ovos-gui changes

companion to OpenVoiceOS/ovos-bus-client#120 and OpenVoiceOS/ovos-gui#53
JarbasAl added a commit to OpenVoiceOS/ovos-skill-news that referenced this pull request Nov 5, 2024
@JarbasAl
fix:allow workshop 2.0.0 (#42)
4e6e6f9 
* fix:allow workshop 3.0.0

* fix: allow latest ovos-gui changes

companion to OpenVoiceOS/ovos-bus-client#120 and OpenVoiceOS/ovos-gui#53
JarbasAl added a commit to OpenVoiceOS/ovos-skill-alerts that referenced this pull request Nov 5, 2024
@JarbasAl
fix: gui resources path (#22)
cbb9af8 
* fix: gui resources path

* fix: allow latest ovos-gui changes

companion to OpenVoiceOS/ovos-bus-client#120 and OpenVoiceOS/ovos-gui#53
JarbasAl added a commit to OpenVoiceOS/ovos-skill-spotify that referenced this pull request Nov 5, 2024
@JarbasAl
fix:allow workshop 3.0.0 (#20)
4dc7867 
* fix:allow workshop 3.0.0

* fix: allow latest ovos-gui changes

companion to OpenVoiceOS/ovos-bus-client#120 and OpenVoiceOS/ovos-gui#53
JarbasAl added a commit to OpenVoiceOS/ovos-skill-naptime that referenced this pull request Nov 5, 2024
@JarbasAl
fix: gui resources path (#35)
c5c0a3b 
* fix: gui resources path

* fix: allow latest ovos-gui changes

companion to OpenVoiceOS/ovos-bus-client#120 and OpenVoiceOS/ovos-gui#53
JarbasAl added a commit to OpenVoiceOS/ovos-skill-boot-finished that referenced this pull request Nov 5, 2024
@JarbasAl
fix:allow workshop 2.0.0 (#30)
d9191db 
* fix:allow workshop 3.0.0

* fix: allow latest ovos-gui changes

companion to OpenVoiceOS/ovos-bus-client#120 and OpenVoiceOS/ovos-gui#53
@coderabbitai coderabbitai bot mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JarbasAl